Added download_data_local.py and updated 5.1 Filtering#3
Open
adiezsanchez wants to merge 12 commits into
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Owner
|
Hi @adiezsanchez. Any reason you closed this PR? Still happy to include your updates, unless there's another problem? |
Contributor
Author
|
Hi @guiwitz felt like it was a lot of changes at once 😅. Maybe I can make multiple smaller commits? I will reopen this anyways so you can check it 😊👍. The segmentation of nuclei was picking up a bit of extra crap though (will need to revisit that). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Guillaume,
As I am running through the notebooks I am updating the code and explanations here and there to clarify a few things. I.e. some parameter names have changed in skimage.filters.median from "selem" to "footprint" in the latest versions of scikit-image.
I created a new download_local_data.py file for people like me that run the notebooks in their own computer so the Data is downloaded and extracted into the directory where the rest of the notebooks import the image files from.
Please discard what you deem unnecessary :)